Portfolio: Mobile and Desktop version
This is a last milestone in the process of creating a portfolio website. Now, I'm adding the preservation of the data added to the Contact Form, in the browser.
Built With
- HTML / CSS (Flexbox-Grid) / JavaScript
Online version
Getting Started
- To get a local copy up, clone the repo like this: git clone [email protected]:cmolinan/Portfolio-setup-and-mobile-version-skeleton.git
Authors
- Carlos Molina GitHub: https://github.com/cmolinan
🤝
Contributing
Contributions, issues, and feature requests are welcome! Feel free to check the issues page. Feel free to check the issues page.
Show your support
Give a
Acknowledgments
To my teammates on Microverse:
- Matias Aguirre
- Haftamu Desta
- David Isea
📝
License
This project is MIT licensed.
Details popup window
Changes
-Creation of a JavaScript array to store the information for all projects. -Update of the main page so that the projects section is created dynamically using the information stored in that JavaScript object. -Implementation of a popup window to show the project details,
Preservation of form data in the Browser
CHANGES
-Code to save of the form data in the local storage of the browser. So that, when the user reloads the page the data they filled out in the form will be preserved.
Accessibility updates
Changes for Accessibility
Page titles Change title to: Carlos Molina Portfolio https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L6
Image text alternatives** (
)
Changes alt to "" -- lines 72,74,101,103,131,133,161,163 (only icons)
https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L72-L74
https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L101-L103
https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L131-L133
https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L161-L163
Changes alt to "" -- lines 66, 95, 124, 154 (card images are not critical info) https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L66 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L95 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L124 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L154
Changes alt to "" -- lines 221, 235, 240 (only icons) https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L221 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L235 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L240
Changes alt to "JavaScript" -- lines 224 and 229 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L224 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L229
Changes alt to "HTML" -- lines 225 and 230 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L225 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L230
Changes alt to "CSS" -- lines 226 and 231 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L226 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L231
Change alt to "End of Portfolio"to line 279 https://github.com/cmolinan/Portfolio-project/blob/main/index.html#L279
Color contrast -No issues found
Resize -No issues found
Interaction -No issues found
Moving content -No issues found
Multimedia -No issues found
The basic structure of the page -No issues found
Script section not working
Your script was not working due to the misspelling of Id in your first query selector.
https://github.com/cmolinan/Portfolio-project/blob/6377e320a02671485e099e3e247c2fea786beb0c/code.js#L1
I already changed 'mobileMenu' to 'MobileMenu'
Peer to Peer Code Review
Suggestion from Morning Team
Add linters to local enviroment to avoid meaningless commits for linter checks
I think it would make it easier for you to work if you installed the linters locally so you could check for linters locally instead of pushing them to GitHub and letting GitHub Actions check linters for you.
You can find more information on this link:
https://github.com/microverseinc/linters-config/tree/master/html-css
issues found in carlos mobile version
hi Carlos your design is fascinating we liked a lot your choice of colors and your implementation of Figma design however here is a list of things we thought you need to invest more time to improve:-