As requested in #202 by @joshdmiller here's my request for external partial support for popover which would make popover much more versatile and lower the need of duplicate code in the apps. Already working implementation can be found in one of the "competing" Bootstrap implementations at http://mgcrea.github.com/angular-strap/#/popover.

Update: This is ready to merge. ~~Here's a poll for anybody to get involved in voting to name this directive: http://goo.gl/forms/oxW1B4L81B~~ Thank you. It'll be called popover-template and tooltip-template.

Update: I finally got to this. This should be ready for testing.

TODO:

• [x] Needs Tests
• [x] Needs documentation
• [x] Doesn't support live updating of the positioning after the template has been reloaded
• [x] Doesn't support changing of the template URL (there's no watcher)

This is a proof of concept to use a tooltipController to transclude a template.

It's based off #1600 and most of the changes are from that. See https://github.com/chrisirhc/angular-ui-bootstrap/commit/0a1510c957bd385db61dcb1a8366fef97fd38e74 for actual changes for the popoverWindow.

Tests are missing but I wanted to open this up for discussion or comment.

Fixes #220

Hi guys, thanks for your nice work. I would like to ask you when do you start support bootstrap 3.0. Some directives work some don't. E.g. modal doesn't work.

I am developing new app but for me (IMHO for many other developers too) is better to start to build new project on BS3 WIP version because I hope it come sooner then I finish my app.

I would like to propose create BS3 branch now and start to modify directives for it.

What do you think about it?

Under certain circumstances, the modal dialog will simply disappear instead of fading out (even though it successfully fades in).

The example in the documentation is what it should do (fade in and out). https://angular-ui.github.io/bootstrap/#/modal

Ironically, the plunker link it generates shows the modal not properly fading out. I've saved my own to serve as an example here: http://plnkr.co/edit/lmFTpQtfgV6qB4AuFrXj?p=preview [Edit from @chrisirhc to reduce confusion: Please take note that the above Plunker does not include angular-animate. As such, no animations should be seen. This is a new requirement for animations, see README.]

I have the same issue in a separate project of mine where I am handling the modal differently but have the same bug. I can provide the 2nd example if it would help but I imagine the plunker should be enough.

The bug appears to be browser independent as it occurs both when I use Chrome v42.0.2311.135 m and in the developer edition of Firefox (39.0a2).

UPDATE: Note that the plnkr is using the latest version of angular-ui (0.13.0) and the latest supported version of angular (1.3.13). This is not about angular 1.4.

IMPT Read bottom message, Bootstrap update has likely fixed this

To be more precise, broken due to this commit: https://github.com/twbs/bootstrap/pull/14927/files

Temporary workaround: override new css code with older one

https://github.com/angular-ui/bootstrap#impt---2015-plans-and-angular-13-support

I think that at this point it is cleat to everyone that the current $dialog service got in a state where it is hardy maintainable. There are tons of issues opened for it and some of the design decisions make it impossible to move forward with the current code.

I'm in the process of re-writing the current service and the modal directive, will try to push the first version for review over the weekend (if everything goes as planned).

Going to close all the existing issues for $dialog and 'modal' as a duplicate of this one.

As a reminder, early draft of the design is available here: https://gist.github.com/ajoslin/5477996

@ajoslin I'm not sure if keeping is as gist is the best thing at the moment as I can't easily modify it. Not sure how to progress - I can fork of course but how do we merge all the versions? Anyway I will be working on the forked gist for now.

It could be interresting to automatically open the suggestion view when the input field has focus.

It will allow user to see choices it can make when a filter is used and the list is not editable.

What do you think about ?

Say I instantiate a modal:

$modal.open({
  controller: 'MyCtrl'
});

In my modal, I have a form:

<form name="myForm">...</form>

Because of transclusion, myForm is not available on MyCtrl's scope and I can't check for $valid, for example. A workaround I've found is to simply put an ng-controller="MyCtrl" within my modal template itself, and do this:

$modal.open({
  controller: function($scope, $modalInstance) {
    $scope.$modalInstance = $modalInstance;
  }
});

...and now I can get to the instance from within MyCtrl.

This is not ideal, but I'm not sure of what the fix should be. Instead of transclusion, would it be a good idea to actually insert an ngController directive within the template/modal/window.html template itself then say, ngTransclude within a child tag? Any better way to tackle this problem?

thanks Chris

hide triggers when a click occurs that does not target the popover/tooltip link and does not target elements with the popover/tooltip classes

This solves issue #1055 and helps with similar issues (#618, #590, #749, #751)

Let me know if this is something that's desired and if an option needs to be added for toggling this behavior.

Hi. As I explained in my case in Stack Overflow (http://stackoverflow.com/questions/18716904/positioning-angular-ui-bootstrap-datepicker) I am having a problem with the positioning in the datepicker. It always appears below the input that invoke it from the bottom left corner. But if the input is close to the right border of the page, the datepicker is cut and a horizontal scroll appears.

I am writing because I think it would be a nice feature to handle the alignment in the datepicker configuration.

Hoping you take this into consideration

Kind Regards Andrey Bottoni

Hello,

I want to ask if you're considering support of angular.component method which is new API for creating components.

I'd like to have the ability to call $modal.open method with the component definition. Now I have to specify controller and template options...

My API proposal:

angular.module('myApp').component('myModal', {
  bindings: {
    greeting: '<'
  },
  template: '<div>{{$ctrl.greeting}}</div>',
  controller: function () {},
})

// open the modal
$modal.open({
  component: 'myModal',
  bindings: {
    greeting: 'hello',
  },
});

Thanks for response.

O.

Bug description:

Hello, I got some trouble with uib modal, Sometimes, it's totally random, when I close modal using $uibModalInstance.close(smth) method, it doesn't close properly. I saw lot's of the same issue but can't find the same setup as mine. And as a said it's totally random, i can't reproduce it to make it work 100%.

Link to minimally-working plunker that reproduces the issue:

Here's a plunker reproducing my issue with older version, I don't want to use older version of angular or UIBS

http://plnkr.co/edit/lQMQm5NJuRHkTBfER7cq?p=preview

Steps to reproduce the issue:

Here's my code: Call modal Method:

var modalInstance = $uibModal.open({
                    animation: true,
                    controller: 'ModalInfoMouvementCtrl',
                    templateUrl: '/otawa/infomouvement',
                    size: 'lg',
                    backdrop: 'static',
                    keyboard: true,
                    resolve: {
                        param: function () {
                            return { mouvement: mvt };
                        }
                    }
                });
                modalInstance.result.then(function (mvt) {
                    if (mvt != null) {
                        var respa = mouvementSrv.getMouvementById(mvt.id);
                        respa.then(function (response) {
                            var mvt = convertMouvementData(response.data);
                            $scope.listMouvement[index] = mvt;
                            $scope.selectedmvt = null;
                        }, function (err, status) {
                            $toastr.error(err.data, 'Erreur');
                        });
                    }
                    reloadInstance();
                }, function () {
                });

Closing method on other Controller :

  $scope.close = function (mvt) {
                $uibModalInstance.close(mvt);
            }

Calling modal on button click, then when i finish to fill my form inside the modal, it fade out but I can't click anywhere, and if I inspect HTML i can see the modal HTML.

Set animation false do not solve the bug.

Any suggestion of what could be wrong ?

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.6 Angular Animate : 1.5.6

UIBS: 2.5.0

Bootstrap: 3.3.7

Bug description:

I'm using a uib-popover with outsideClick trigger. The popover outsideClick trigger works except on mobile(tested on iOS)

Steps to reproduce the issue:

Click link to open a popover Click in an outside area

Popover should disappear and now its not.

Version of Angular, UIBS, and Bootstrap

Angular:1.5.11

UIBS:2.5.0

Bootstrap:3.3.7

Closes 6636

change the datepicker activeDate so it uses a copy of the initDate instead of a reference to initDate. This way when the user clicks Next or Previous, activeDate changes but initDate does not.

https://github.com/angular-ui/bootstrap/issues/6636

Bug description:

I've added ui-bootstrap to an angular 1.x project and getting this error when I want to open a modal form

[$compile:tpload] Failed to load template: uib/template/modal/window.html (HTTP status: 404 Not Found)

I've used ui-bootstrap before and always it worked well but in my new project I have problem with it.

the code is like : $uibModal.open({ backdrop: 'static', templateUrl: 'DesktopModules/' + window.GLOB.moduleFolderName + '/app/form/form.html', controller: 'requestCtrl', size: 'sm', scope: $scope }); angular ver : v1.5.8

UIBS: v2.2.0

Bootstrap: v3.3.7

The issues forum is NOT for support requests. It is for bugs and feature requests only. Please read https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md and search existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description: As the user navigates the datepicker control, the initDate is updated. This causes issues if you use the the current date of one datepicker as the initDate of another.

Also, note how the Start Date control itself doesn't change, but the model value does.

Expected: initDate is essentially readonly.

Link to minimally-working plunker that reproduces the issue:

https://plnkr.co/edit/tvelT5r6ho59zcPzPvIH?p=preview

Steps to reproduce the issue:

As noted in the Plunker, simply navigate forward or backward by month in the End Date datepicker and note how the Start Date value changes.

Version of Angular, UIBS, and Bootstrap

Angular: 1.6.1

UIBS: 2.5.0

Bootstrap: 3.3.7